New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store verifies digest lengths internally #6588

Merged
merged 2 commits into from Oct 5, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented Oct 3, 2018

Without this change, ensure_remote_has_recursive may return Ok even
though the Digest being uploaded doesn't get uploaded.

Store verifies digest lengths internally
Without this change, ensure_remote_has_recursive may return Ok even
though the Digest being uploaded doesn't get uploaded.

@illicitonion illicitonion requested review from ity , blorente and dotordogh Oct 3, 2018

@stuhood

stuhood approved these changes Oct 4, 2018

Ok(bytes) => {
if bytes.len() == digest.1 {
Ok(Some(f(Bytes::from(bytes))))
} else {

This comment has been minimized.

@stuhood

stuhood Oct 4, 2018

Member

Does this case represent a hash collision...? If so, should we be noisier?

This comment has been minimized.

@illicitonion

illicitonion Oct 5, 2018

Contributor

Done

@stuhood

stuhood approved these changes Oct 5, 2018

@stuhood stuhood merged commit 9df7cee into pantsbuild:master Oct 5, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Oct 5, 2018

Shard 3 is the only failure here (fixed by #6600). Merging.

@stuhood stuhood deleted the twitter:dwagnerhall/remoting/storeverifylength branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment