New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify factory method terminal constructor calls. #6625

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

jsirois commented Oct 12, 2018

No description provided.

@Eric-Arellano
Copy link
Contributor

Eric-Arellano left a comment

Looks good. Thanks

@jsirois jsirois merged commit 6c47ba2 into pantsbuild:master Oct 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/5764/review-follow-up branch Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment