New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split conan resolve by native_external_library targets (takeover). #6630

merged 3 commits into from Oct 15, 2018


None yet
2 participants
Copy link

cosmicexplorer commented Oct 14, 2018

Takeover of #6492 (which has completely passed review) as it was blocked by progress on two other PRs I have up (#6486, #6628) due to potential merge conflicts, which I can resolve when they come up for each of these PRs to unblock landing them in parallel.

Copy link

stuhood left a comment


def _make_compile_request(self, versioned_target, dependencies, external_libs_product):
target =

include_dirs = [self._include_dirs_for_target(dep_tgt) for dep_tgt in dependencies]
include_dirs.extend(self._get_third_party_include_dirs(external_libs_product, dependencies))
print('>>> include_dirs: {}'.format(include_dirs))

This comment has been minimized.


This comment has been minimized.


cosmicexplorer Oct 14, 2018



cosmicexplorer added some commits Oct 14, 2018

@cosmicexplorer cosmicexplorer merged commit f679089 into pantsbuild:master Oct 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment