New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dep-usage] when no summary, ensure json output is unicode #6641

Merged
merged 2 commits into from Oct 17, 2018

Conversation

Projects
None yet
2 participants
@baroquebobcat
Copy link
Contributor

baroquebobcat commented Oct 16, 2018

Problem

When no summary is requested for dep usage, generating the json blows up due to a type mismatch.

Solution

Convert the json into unicode by using the builtin.

Result

The added test for a no-summary invoke passes.

[dep-usage] when no summary, ensure json output is unicode
### Problem
When no summary is requested for dep usage, generating the json blows up due to a type mismatch.

### Solution
Convert the json into unicode by using the builtin.

### Result
The added test for a no-summary invoke passes
@stuhood
Copy link
Member

stuhood left a comment

Thanks!

@@ -7,7 +7,7 @@
import json
import os
import sys
from builtins import next, object, open
from builtins import next, object, open, str as text

This comment has been minimized.

@stuhood

stuhood Oct 16, 2018

Member

Should probably use the default name for the str function.

@baroquebobcat

This comment has been minimized.

Copy link
Contributor

baroquebobcat commented Oct 16, 2018

@baroquebobcat baroquebobcat merged commit 1fb3cf5 into pantsbuild:master Oct 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment