Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[dep-usage] when no summary, ensure json output is unicode #6641
I can do that.…
On Tue, Oct 16, 2018, 5:27 PM Stu Hood ***@***.***> wrote: ***@***.**** approved this pull request. Thanks! ------------------------------ In src/python/pants/backend/jvm/tasks/jvm_dependency_usage.py <#6641 (comment)>: > @@ -7,7 +7,7 @@ import json import os import sys -from builtins import next, object, open +from builtins import next, object, open, str as text Should probably use the default name for the str function. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6641 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAc0k39T_vPvGs3UG_-KxsxxxESootwks5ulmtigaJpZM4XieFl> .
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.