New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resolving `Checker` from `sys.path`. #6642

Merged
merged 2 commits into from Oct 17, 2018

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

jsirois commented Oct 17, 2018

Notably, this allows resolving the Checker from within a pants pex.

Fixes #6639

Support resolving `Checker` from `sys.path`.
Notably, this allows resolving the `Checker` from within a pants pex.

Fixes #6639
@stuhood
Copy link
Member

stuhood left a comment

This is really lovely. Thank you John!

log=self.context.log)
try:
# The checker is already on sys.path, eg: embedded in pants.pex.
working_set = WorkingSet(entries=sys.path)

This comment has been minimized.

@stuhood

stuhood Oct 17, 2018

Member

This is wild.

Install the wheel directly for `sys.path` tests.
It turns out the `install` setup command installs a `py27` egg and there
is no obvious way to coerce it into anything like a universal wheel such
that the egg is resolved when testing against python 3; so just install
the universal wheel we already built.

@jsirois jsirois requested a review from blorente Oct 17, 2018

@jsirois jsirois merged commit 882d8ce into pantsbuild:master Oct 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/6639 branch Oct 17, 2018

@stuhood stuhood referenced this pull request Oct 18, 2018

Merged

Prep for 1.11.0rc0 #6636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment