New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console_rule generators, and add a test to cover running them under run_rule. #6644

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

stuhood commented Oct 17, 2018

Problem

@console_rules do not currently support being run as generators.

Solution

Add support for running as generators, and add a test to cover running them under run_rule for unit testing.

@stuhood stuhood requested review from illicitonion and kwlzn Oct 17, 2018

@illicitonion
Copy link
Contributor

illicitonion left a comment

Thanks!

@stuhood stuhood merged commit 45614bb into pantsbuild:master Oct 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/console-rule-generators branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment