New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten up checkstyle plugin subsystem option passing. #6648

Merged
merged 1 commit into from Oct 18, 2018

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

jsirois commented Oct 17, 2018

Ensure we only try to pass options declared by checkstyle plugins.

Fixes #6645

Tighten up checkstyle plugin subsystem option passing.
Ensure we only try to pass options declared by checkstyle plugins.

Fixes #6645

@jsirois jsirois requested review from stuhood and CMLivingston Oct 17, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Oct 17, 2018

Thank you! Checking this out end-to-end via https://travis-ci.org/pantsbuild/pants/builds/442943012

@stuhood
Copy link
Member

stuhood left a comment

Thanks! Feel free to merge on green: if you merge before my smoketest starts building, I'll cancel it and just use the wheels from master.

options = self.get_options()
options_dict = {option: options.get(option) for option in options}
options_dict = {option: options.get(option)

This comment has been minimized.

@stuhood

stuhood Oct 17, 2018

Member

It would be useful to land this without another CI iteration, and it looks sane.

But I think that it might be possible to do this with self.get_options().for_scope(.., inherit_from_enclosing_scope=False).

This comment has been minimized.

@jsirois

jsirois Oct 18, 2018

Member

I'm not seeing how to do this. It's self.get_options() -> OptionValueContainer and not self.get_options() -> Options.

@jsirois jsirois merged commit 103c0a6 into pantsbuild:master Oct 18, 2018

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/6645 branch Oct 18, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Oct 18, 2018

Confirmed fixed internally! Thanks John.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment