New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection is iterable #6649

Merged
merged 1 commit into from Oct 18, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Contributor

illicitonion commented Oct 18, 2018

This is more idiomatic to use from Python than calling .dependencies

Also, update to non-deprecated test base class

Collection is iterable
This is more idiomatic to use from Python than calling .dependencies

Also, update to non-deprecated test base class

@illicitonion illicitonion requested review from stuhood and blorente Oct 18, 2018

@blorente

Looks great QoL, thanks!

@stuhood

Thanks!

@stuhood

This comment has been minimized.

Member

stuhood commented Oct 18, 2018

Only failure is due to rc0 not yet being published. Merging.

@stuhood stuhood merged commit 77e9579 into pantsbuild:master Oct 18, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@stuhood stuhood deleted the twitter:dwagnerhall/v2/collectioniter branch Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment