New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow v2-only goals to be implicitly registered #6653

Merged
merged 1 commit into from Oct 18, 2018

Conversation

2 participants
@illicitonion
Contributor

illicitonion commented Oct 18, 2018

If a @console_task is registered with a goal name, that goal will be
registered, even if no v1 goal exists with that name.

This is pretty hacky, and should be replaced by something better soon.
See #6651.

Fixes #6650

Allow v2-only goals to be implicitly registered
If a @console_task is registered with a goal name, that goal will be
registered, even if no v1 goal exists with that name.

This is pretty hacky, and should be replaced by something better soon.
See #6651.

Fixes #6650

@illicitonion illicitonion requested a review from stuhood Oct 18, 2018

@illicitonion illicitonion added this to To Do in Python Pipeline Porting via automation Oct 18, 2018

@stuhood stuhood moved this from To Do to In Progress in Python Pipeline Porting Oct 18, 2018

@stuhood

This comment has been minimized.

Member

stuhood commented Oct 18, 2018

Only ci failures are from the rc0 issue. Merging.

@stuhood stuhood merged commit f28708d into pantsbuild:master Oct 18, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

Python Pipeline Porting automation moved this from In Progress to Done Oct 18, 2018

@stuhood stuhood deleted the twitter:dwagnerhall/v2/goalregistration branch Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment