New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the FSEventService pool in favor of execution on the dedicated service thread. #6667

Merged
merged 2 commits into from Oct 24, 2018

Conversation

Projects
None yet
2 participants
@stuhood
Member

stuhood commented Oct 21, 2018

No description provided.

future = executor.submit(file_toucher)
thread = threading.Thread(target=file_toucher)
thread.start()

This comment has been minimized.

@jsirois

jsirois Oct 22, 2018

Member

Adding a thread.daemon = True before start would be good form to gaurd against abends.

@stuhood stuhood merged commit faeaf07 into pantsbuild:master Oct 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/remove-fs-service-executor branch Oct 24, 2018

stuhood added a commit that referenced this pull request Oct 29, 2018

stuhood added a commit that referenced this pull request Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment