New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-flake JarPublishTest. #6726

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
2 participants
@jsirois
Member

jsirois commented Nov 5, 2018

Previously, a dict was used unnecessarily in target preparation leading
to unexpected results when attempting to access a particular target
instead of all prepared targets as a whole.

Fixes #6382

De-flake JarPublishTest.
Previously, a dict was used unnecessarily in target preparation leading
to unexpected results when attempting to access a particular target
instead of all prepared targets as a whole.

Fixes #6382

@jsirois jsirois requested a review from Eric-Arellano Nov 5, 2018

@jsirois

This comment has been minimized.

Member

jsirois commented Nov 5, 2018

@OniOni I sent you an invite to become a "contributor". This will allow assigning you to issues and adding you as a reviewer.

@Eric-Arellano

Thanks for taking us over the finish line! 🎉

targets="$(comm -23 <(./pants.pex --tag='-integration' list tests/python:: | grep '.' | sort) <(sort "${REPO_ROOT}/build-support/known_py3_failures.txt"))"
else
targets="tests/python::"
fi

This comment has been minimized.

@Eric-Arellano

Eric-Arellano Nov 5, 2018

Contributor

Think it's worth keeping any of this for setting up our integration test blacklist? The implementations sounds like it will have to be different by setting up a shard that runs the skipped tests using Py2, so probably not worth keeping.

This comment has been minimized.

@jsirois

jsirois Nov 5, 2018

Member

Kill things dead when they are no longer used right now. We have git and github to aide memory if need be.

This comment has been minimized.

@Eric-Arellano

Eric-Arellano Nov 5, 2018

Contributor

Very true. And Mateo and I were big advocates of this at Foursquare so sad I suggested this hah.

@jsirois jsirois merged commit 9595d49 into pantsbuild:master Nov 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/6382 branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment