New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to assert that type validation works for Get #6731

Merged
merged 2 commits into from Nov 6, 2018

Conversation

Projects
None yet
2 participants
@dotordogh
Contributor

dotordogh commented Nov 6, 2018

Problem

According to #6656, Get wasn't validating its inputs. However, upon reading the code, its inputs should be validated at runtime.

Solution

I added a test to ensure the validation behavior is correct.

@dotordogh dotordogh requested a review from stuhood Nov 6, 2018

@stuhood

stuhood approved these changes Nov 6, 2018

Thanks!

@dotordogh dotordogh merged commit dbbff71 into pantsbuild:master Nov 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment