Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run integration test against Python 3 #6732

Merged
merged 14 commits into from Nov 9, 2018
Merged

Conversation

@OniOni
Copy link
Contributor

@OniOni OniOni commented Nov 7, 2018

Problem

As we push towards python 3 support for pants, we want more than our unit tests to run against python 3.

Solution

Run integration tests against python 3

Notes:

  • As the cost of running integration test against both python 2 and 3 is too costly, it was decided we would switch CI to run python 3 only with a daily cron job running same tests against python 2
  • We have a blacklist at build-support/known_py3_integration_failures.txt for all tests failing in python3. We do run those tests against python2.
  • I added 1 shard and reshuffled integration shards. So we now have 8 integration tests shards, 6 for python 3 and 2 for python 2 (blacklisted tests).
@OniOni OniOni changed the title [feat] Get travis to run integration tests with python >= 3.4. Run integration test against Python 3 Nov 7, 2018
@Eric-Arellano Eric-Arellano requested a review from jsirois Nov 9, 2018
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

This looks great. Thanks Mathieu!

John / others, we yesterday tested out how the cron job works. In Travis's dashboard, we choose a branch and set it to run "daily". It will run every 24 hours after the first setup. So, once we merge this PR, we will set up a cron job agains the master branch. With Mathieu's .travis.yml config, that Cron job will only run the Py2 integration shards. See below image for config and yesterday's test we ran.

screen shot 2018-11-09 at 11 45 47 am

We'll need to decide when is the ideal time to run the cron job? Something like 2 am? PST or EST?

@Eric-Arellano Eric-Arellano requested a review from stuhood Nov 9, 2018
@jsirois
jsirois approved these changes Nov 9, 2018
Copy link
Member

@jsirois jsirois left a comment

LGTM!

@Eric-Arellano Eric-Arellano merged commit add3f21 into pantsbuild:master Nov 9, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
wisechengyi added a commit to wisechengyi/pants that referenced this pull request Nov 12, 2018
### Problem
As we push towards python 3 support for pants, we need integration tests to also run against python 3. 

### Solution
Run integration tests against python 3

### Notes:
- As the cost of running integration test against both python 2 and 3 is too costly, it was decided we would switch CI to run python 3 only with a daily cron job running same tests against python 2. This Cron job is managed in the Travis dashboard.
- We have a blacklist at `build-support/known_py3_integration_failures.txt` for all tests failing in python3. We do run those tests against python2.
- We added 1 shard and reshuffled integration shards. So we now have 8 integration tests shards, 6 for python 3 and 2 for python 2 (blacklisted tests).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants