Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Ignore paths more deeply to avoid graph impact when ignored files are added/removed #6752
The path ignoring that is controlled by the
Push path filtering down to
Node dirtying should be effective in more cases, because creating/removing a file at an ignored path will only clear a single node, while all other nodes can be cleaned without re-running.
Example for creating a file
Creating a non-fragile test is going to take some refactoring in this case, because we're missing the framework we'd need to test how many nodes needed to re-run in the context of a full pants run. There are solid tests of invalidation and precise node runs in https://github.com/pantsbuild/pants/blob/master/src/rust/engine/graph/src/lib.rs#L787 , but having tests that can inspect which
I could create a pantsd test that greps logs for the patterns seen above, but I think I'd prefer to open a followup ticket with a suggestion of how to do this holistically.
referenced this pull request
Nov 9, 2018
I added #6753 to cover the holes in our test infrastructure which make it difficult to add tests for cases like these. The solution to that ticket will likely arrive in multiple parts and should be scheduled alongside upcoming feature work or bug fixing in node dirtying or