New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 3 option integration test issue with unicode #6755

Merged
merged 1 commit into from Nov 10, 2018

Conversation

Projects
None yet
3 participants
@OniOni
Contributor

OniOni commented Nov 9, 2018

Problem

Python 3 makes a big deal about string and bytes are totally different.

Solution

Make sure we convert the bytes to a string.

Result

Test is fixed.

@Eric-Arellano Eric-Arellano changed the title from [fix] Python 3 cares a lot that bytes and strings are different. to Fix Python 3 option integration test issue with unicode Nov 10, 2018

@Eric-Arellano Eric-Arellano merged commit 2ee9b42 into pantsbuild:master Nov 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

wisechengyi added a commit to wisechengyi/pants that referenced this pull request Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment