New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSX 10.12 and 10.13 #6760

Merged
merged 6 commits into from Nov 15, 2018

Conversation

Projects
None yet
5 participants
@blorente
Contributor

blorente commented Nov 12, 2018

Problem

We do not test that pants can work in older OSX versions.

Solution

Add two shards to Travis, one for the earliest version of OSX 10.12 (xcode8.3) and another for the earliest version of 10.13 (9.3).
Travis OSX version documentation

Acknowledgements

Paired with @dotordogh

@blorente blorente force-pushed the blorente:dotbor/travis branch from eb301f0 to 51af48f Nov 12, 2018

@stuhood

This comment has been minimized.

Member

stuhood commented Nov 13, 2018

Very mysterious that this didn't kick off travis. Will make an edit and see if that changes things.

@dotordogh

This comment has been minimized.

Contributor

dotordogh commented Nov 13, 2018

I also tried pushing the branch to origin and it doesn't appear in travis. It's all very strange.

@wisechengyi

This comment has been minimized.

Contributor

wisechengyi commented Nov 13, 2018

That usually means travis can't parse the the yml, so some syntax error likely.

@dotordogh

This comment has been minimized.

Contributor

dotordogh commented Nov 13, 2018

Thanks to @wisechengyi, this is being picked up automatically by travis 🎉

Dorothy Ordogh

@dotordogh dotordogh requested a review from stuhood Nov 13, 2018

@stuhood

We are doing a few different checks with both XCode 8 (binary builder shard) and 8.3 (OSX rust and platform specific tests), so it might be good to spread these wider through the range, rather than focusing on older platforms... maybe up to the very latest 10.13 (and then 10.14, once it's available).

@@ -92,6 +92,13 @@ default_test_config: &default_test_config
# files in the working copy.
- sudo sysctl fs.inotify.max_user_watches=524288
osx_test_config: &osx_test_config

This comment has been minimized.

@stuhood

stuhood Nov 14, 2018

Member

Given that these are only intended to be sanity checks, and are not going to run tons of tests, I'd recommend using MODE=debug to cut down on the bootstrap time. If we were going to add a bunch more tests here we'd want to consider removing it.

@stuhood stuhood merged commit dd14eb2 into pantsbuild:master Nov 15, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment