New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exec-graph] catch BaseException; improve inprogress debug logging #6773

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
2 participants
@baroquebobcat
Contributor

baroquebobcat commented Nov 15, 2018

Without catching BaseException, lower level python errors will cause graph execution hangs and not propagate the error.

This also improves the in progress logging to look something like this

               Running   (1):
                 compile(src/scala/org/pantsbuild/zinc/compiler:compiler)
               Queued    (5):
                 compile(src/java/org/pantsbuild/testing:testing)
                 compile(src/java/org/pantsbuild/tools/ivy:ivy-dependency-update-checker)
                 compile(src/java/org/pantsbuild/tools/runner:runner-library)
                 compile(src/scala/org/pantsbuild/zinc/bootstrapper:bootstrapper)
                 compile(src/scala/org/pantsbuild/zinc/extractor:extractor)
               Unstarted (0):
[exec-graph] catch BaseException; improve inprogress debug logging
Without catching BaseException, lower level python errors will cause graph execution hangs and not propagate the error.

This also improves the in progress logging to look something like this

                   Running   (1):
                     compile(src/scala/org/pantsbuild/zinc/compiler:compiler)
                   Queued    (5):
                     compile(src/java/org/pantsbuild/testing:testing)
                     compile(src/java/org/pantsbuild/tools/ivy:ivy-dependency-update-checker)
                     compile(src/java/org/pantsbuild/tools/runner:runner-library)
                     compile(src/scala/org/pantsbuild/zinc/bootstrapper:bootstrapper)
                     compile(src/scala/org/pantsbuild/zinc/extractor:extractor)
                   Unstarted (0):
@illicitonion

Thanks!

@baroquebobcat baroquebobcat merged commit 8cade53 into pantsbuild:master Nov 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment