New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip broken test_pantsd_parent_runner_killed #6779

Merged
merged 1 commit into from Nov 16, 2018

Conversation

Projects
None yet
3 participants
@wisechengyi
Contributor

wisechengyi commented Nov 16, 2018

Filed #6778

@cosmicexplorer

cosmicexplorer approved these changes Nov 16, 2018 edited

It's extremely easy to find and fix skipped unit tests in the future -- we don't have that many, so this seems like the right approach in most cases.

@benjyw

benjyw approved these changes Nov 16, 2018

@wisechengyi

This comment has been minimized.

Contributor

wisechengyi commented Nov 16, 2018

Failed at a unrelated thing

                     tests/python/pants_test/engine/test_engine.py::EngineTest::test_trace_multi <- pyprep/sources/def4ffc9e8c0d8c09b1625727c5c9f0c311dca15/pants_test/engine/test_engine.py FAILED [100%]
                     
                     ==================== FAILURES ====================
                     __________ EngineTest.test_trace_multi ___________
                     
                     self = <pants_test.engine.test_engine.EngineTest testMethod=test_trace_multi>
                     
                         def test_trace_multi(self):
                           # Tests that when multiple distinct failures occur, they are each rendered.
                           rules = [
                             RootRule(B),
                             TaskRule(D, [Select(B)], nested_raise),
                             TaskRule(C, [Select(B)], nested_raise),
                             TaskRule(A, [Select(C), Select(D)], A),
                           ]
                         
                           scheduler = self.scheduler(rules, include_trace_on_error=True)
                           with self.assertRaises(ExecutionError) as cm:
                             list(scheduler.product_request(A, subjects=[(B())]))
                         
                           self.assert_equal_with_printing(dedent('''
                               1 Exception encountered:
                               Computing Select(<pants_test.engine.test_engine.B object at 0xEEEEEEEEE>, =A)
                                 Computing Task(A, <pants_test.engine.test_engine.B object at 0xEEEEEEEEE>, =A, true)
                                   Computing Task(nested_raise, <pants_test.engine.test_engine.B object at 0xEEEEEEEEE>, =D, true)
                                     Throw(An exception for B)
                                       Traceback (most recent call last):
                                         File LOCATION-INFO, in call
                                           val = func(*args)
                                         File LOCATION-INFO, in nested_raise
                                           fn_raises(x)
                                         File LOCATION-INFO, in fn_raises
                                           raise Exception('An exception for {}'.format(type(x).__name__))
                                       Exception: An exception for B
                         
                         
                               Computing Select(<pants_test.engine.test_engine.B object at 0xEEEEEEEEE>, =A)
                                 Computing Task(A, <pants_test.engine.test_engine.B object at 0xEEEEEEEEE>, =A, true)
                                   Computing Task(nested_raise, <pants_test.engine.test_engine.B object at 0xEEEEEEEEE>, =C, true)
                                     Throw(An exception for B)
                                       Traceback (most recent call last):
                                         File LOCATION-INFO, in call
                                           val = func(*args)
                                         File LOCATION-INFO, in nested_raise
                                           fn_raises(x)
                                         File LOCATION-INFO, in fn_raises
                                           raise Exception('An exception for {}'.format(type(x).__name__))
                                       Exception: An exception for B
                               ''').lstrip()+'\n',
                     >       remove_locations_from_traceback(str(cm.exception)))
                     
                     pants_test/engine/test_engine.py:190: 
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     pants_test/engine/util.py:143: in assert_equal_with_printing
                         test_case.assertEqual(expected, str_actual)
                     E   AssertionError: "1 Ex[667 chars]B\n\n\nComputing Select(<pants_test.engine.tes[607 chars]\n\n" != "1 Ex[667 chars]B\n\n"
                     E   Diff is 1357 characters long. Set self.maxDiff to None to see it.
                     -------------- Captured stdout call --------------
                     Expected:
                     1 Exception encountered:
                     Computing Select(<pants_test.engine.test_engine.B object at 0xEEEEEEEEE>, =A)
                       Computing Task(A, <pants_test.engine.test_engine.B object at 0xEEEEEEEEE>, =A, true)
                         Computing Task(nested_raise, <pants_test.engine.test_engine.B object at 0xEEEEEEEEE>, =D, true)
                           Throw(An exception for B)
                             Traceback (most recent call last):
                               File LOCATION-INFO, in call
                                 val = func(*args)
                               File LOCATION-INFO, in nested_raise
                                 fn_raises(x)
                               File LOCATION-INFO, in fn_raises
                                 raise Exception('An exception for {}'.format(type(x).__name__))
                             Exception: An exception for B
                     
                     
                     Computing Select(<pants_test.engine.test_engine.B object at 0xEEEEEEEEE>, =A)
                       Computing Task(A, <pants_test.engine.test_engine.B object at 0xEEEEEEEEE>, =A, true)
                         Computing Task(nested_raise, <pants_test.engine.test_engine.B object at 0xEEEEEEEEE>, =C, true)
                           Throw(An exception for B)
                             Traceback (most recent call last):
                               File LOCATION-INFO, in call
                                 val = func(*args)
                               File LOCATION-INFO, in nested_raise
                                 fn_raises(x)
                               File LOCATION-INFO, in fn_raises
                                 raise Exception('An exception for {}'.format(type(x).__name__))
                             Exception: An exception for B
                     
                     
                     Actual:
                     1 Exception encountered:
                     Computing Select(<pants_test.engine.test_engine.B object at 0xEEEEEEEEE>, =A)
                       Computing Task(A, <pants_test.engine.test_engine.B object at 0xEEEEEEEEE>, =A, true)
                         Computing Task(nested_raise, <pants_test.engine.test_engine.B object at 0xEEEEEEEEE>, =D, true)
                           Throw(An exception for B)
                             Traceback (most recent call last):
                               File LOCATION-INFO, in call
                                 val = func(*args)
                               File LOCATION-INFO, in nested_raise
                                 fn_raises(x)
                               File LOCATION-INFO, in fn_raises
                                 raise Exception('An exception for {}'.format(type(x).__name__))
                             Exception: An exception for B
                     
                     
                      generated xml file: /home/travis/build/pantsbuild/pants/.pants.d/test/pytest/tests.python.pants_test.engine.engine/junitxml/TEST-tests.python.pants_test.engine.engine.xml 
                     ============ slowest 3 test durations ============
                     0.18s call     pyprep/sources/def4ffc9e8c0d8c09b1625727c5c9f0c311dca15/tests/python/pants_test/engine/test_engine.py::EngineTest::test_fork_context
                     0.04s call     pyprep/sources/def4ffc9e8c0d8c09b1625727c5c9f0c311dca15/tests/python/pants_test/engine/test_engine.py::EngineTest::test_include_trace_error_raises_error_with_trace
                     0.02s call     pyprep/sources/def4ffc9e8c0d8c09b1625727c5c9f0c311dca15/tests/python/pants_test/engine/test_engine.py::EngineTest::test_recursive_multi_get
                     ======= 1 failed, 7 passed in 0.78 seconds =======

@wisechengyi wisechengyi merged commit f18dc94 into pantsbuild:master Nov 16, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@wisechengyi wisechengyi deleted the wisechengyi:skip_broken branch Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment