New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Respect 3rdparty resolver setting in BootstrapJvmTools #6789

Merged
merged 14 commits into from Dec 4, 2018

Conversation

Projects
None yet
4 participants
@wisechengyi
Copy link
Contributor

wisechengyi commented Nov 18, 2018

Problem

Currently BootstrapJvmTools would still use ivy despite setting resolver.resolver = coursier. This is highly surprising, confusing, and problematic to set up.

Solution

Have BootstrapJvmTools respects the setting.

Fixes #6675

wisechengyi added some commits Nov 18, 2018

fmt

@wisechengyi wisechengyi changed the title Respects 3rdparty resolver setting in BootstrapJvmTools [wip] Respects 3rdparty resolver setting in BootstrapJvmTools Nov 18, 2018

@wisechengyi

This comment has been minimized.

Copy link
Contributor

wisechengyi commented Nov 18, 2018

Ready for initial review. will add some tests.

@wisechengyi wisechengyi requested review from baroquebobcat and jsirois Nov 18, 2018

@@ -49,7 +49,7 @@ def register_options(cls, register):
],
help='Additional options to pass to coursier fetch. See `coursier fetch --help`')
register('--artifact-types', type=list, fingerprint=True,
default=['jar', 'bundle', 'test-jar', 'maven-plugin', 'src', 'doc', 'aar'],
default=['jar', 'bundle', 'test-jar', 'maven-plugin', 'src', 'doc'],

This comment has been minimized.

@wisechengyi

wisechengyi Nov 18, 2018

Contributor

This is necessary because otherwise coursier will grab the jna-4.5.aar over the jar. Currently we don't have any android users, so it's probably okay.

@wisechengyi wisechengyi changed the title [wip] Respects 3rdparty resolver setting in BootstrapJvmTools [wip] Respect 3rdparty resolver setting in BootstrapJvmTools Nov 18, 2018

wisechengyi added some commits Nov 18, 2018

@wisechengyi wisechengyi changed the title [wip] Respect 3rdparty resolver setting in BootstrapJvmTools Respect 3rdparty resolver setting in BootstrapJvmTools Nov 19, 2018

@wisechengyi

This comment has been minimized.

Copy link
Contributor

wisechengyi commented Nov 19, 2018

Ready for review.

wisechengyi added some commits Dec 1, 2018

@wisechengyi

This comment has been minimized.

Copy link
Contributor

wisechengyi commented Dec 2, 2018

This is ready for another look.

@stuhood

stuhood approved these changes Dec 3, 2018

Copy link
Member

stuhood left a comment

Thanks!

@wisechengyi wisechengyi changed the title Respect 3rdparty resolver setting in BootstrapJvmTools [Fix] Respect 3rdparty resolver setting in BootstrapJvmTools Dec 3, 2018

@wisechengyi wisechengyi changed the title [Fix] Respect 3rdparty resolver setting in BootstrapJvmTools [Bugfix] Respect 3rdparty resolver setting in BootstrapJvmTools Dec 3, 2018

@baroquebobcat
Copy link
Contributor

baroquebobcat left a comment

Looks good to me!

@wisechengyi wisechengyi merged commit c019f4c into pantsbuild:master Dec 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wisechengyi wisechengyi deleted the wisechengyi:6675 branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment