Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Move file owners computation into the engine and make lighter #6790
#5579 added an optimization to avoid hydrating targets, of which a significant portion was later rolled back by #5636. #5636 reasoned that it was necessary to fully construct the graph in order to detect when targets have been deleted.
The solution used in #5636 though, was heavy-handed. By requesting
Additionally, switch back to requesting target adaptor subclasses while building the
is 30 percent faster in the pantsbuild pants repo, primarily due to not expanding source globs.
Generally looks great, but a few things worth a little discussion - thanks for putting this together
Hey gang, thanks for the review! I failed to preserve it via the commits, but one thing to note is that about 80% of this is moved code (
There is a lot of good feedback, but to reduce churn and lower risk, I'd prefer to avoid doing a total overhaul here.
I think the sortedness is an important thing to address before merging, because I don't like the idea of nodes in the engine being non-deterministic.
I'd also like to remove the python filespec implementation pretty eagerly (if not before merging, in a very fast follow), again because of functional inconsistency...
The others, happy to hold off on :)