New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --remote-execution-cache-key-gen-version #6809

Merged
merged 3 commits into from Nov 27, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Nov 26, 2018

Allows for isolated remote execution cache universes

@illicitonion

This comment has been minimized.

Copy link
Contributor

illicitonion commented Nov 26, 2018

I'm really looking forward to being able to consume options on the rust side more directly... :)

Add --remote-execution-cache-key-gen-version
Allows for isolated remote execution cache universes

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/remoting/cachekey branch from 27e5cde to 45471cd Nov 26, 2018

@blorente
Copy link
Contributor

blorente left a comment

That's a lot of work to pass an option to Rust, I agree! Thanks though, it looks great.

Show resolved Hide resolved src/rust/engine/process_execution/src/remote.rs
Show resolved Hide resolved src/rust/engine/src/lib.rs Outdated
@stuhood
Copy link
Member

stuhood left a comment

Thanks.

@@ -295,6 +298,9 @@ def register_bootstrap_options(cls, register):
register('--remote-store-chunk-upload-timeout-seconds', type=int, advanced=True,
default=DEFAULT_EXECUTION_OPTIONS.remote_store_chunk_upload_timeout_seconds,
help='Timeout (in seconds) for uploads of individual chunks to the remote file store.')
register('--remote-execution-cache-key-gen-version', advanced=True,

This comment has been minimized.

@stuhood

stuhood Nov 26, 2018

Member

This might be an opportunity to shorten this name, and have the help refer to the previous name... maybe --remote-execution-cache-namespace?

And given that this will only affect process invokes (and not CAS uploads), maybe --remote-execution-process-cache-namespace (or whatever the remote execution API calls this cache).

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Nov 26, 2018

Fixes #6481.

@illicitonion illicitonion merged commit 475a6ba into pantsbuild:master Nov 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/remoting/cachekey branch Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment