New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dissappearing cursor #6811

Merged
merged 2 commits into from Nov 26, 2018

Conversation

Projects
None yet
4 participants
@blorente
Copy link
Contributor

blorente commented Nov 26, 2018

Problem

When running a rule under the V2 UI, the cursor disappeared at the end, leaving the terminal unusable for further commands.

Solution

Flush the terminal as the last thing it does in finish().

Result

Even though the output of a @console_rule is still broken, the cursor appears after calling pants, which makes it a lot nicer to work on this.

screenshot 2018-11-26 at 16 14 11

Part 1 of #6808

@illicitonion
Copy link
Contributor

illicitonion left a comment

Would it be worth just unconditionally calling flush in write, and having write be unbuffered, so that we don't need to think about whether we need to flush at particular points?

@stuhood stuhood merged commit 95ea9fc into pantsbuild:master Nov 26, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Nov 26, 2018

Only CI failures were flakes. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment