New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pantsbuild.org not example.com #6826

Merged
merged 1 commit into from Nov 28, 2018

Conversation

Projects
None yet
6 participants
@illicitonion
Copy link
Contributor

illicitonion commented Nov 28, 2018

example.com's HTTPS certificate expired today.

At least now we will hold the keys to our own destiny, somewhat.

Use pantsbuild.org not example.com
example.com's HTTPS certificate expired today.

At least now we will hold the keys to our own destiny, somewhat.

@illicitonion illicitonion requested review from stuhood , jsirois and blorente Nov 28, 2018

@blorente
Copy link
Contributor

blorente left a comment

Thanks! LGTM. It would be good to document how we test "things that connect to the internet" in general, but cargo-culting for now sounds fine.

@cosmicexplorer

This comment has been minimized.

Copy link
Contributor

cosmicexplorer commented Nov 28, 2018

Where is this cert stored? It appears trying to access the site https://example.com also shows an error when accessing it from my machine. Why would this cert expire? Is it required to stand up your own website to write integration tests now? This shouldn't be a concern for us as we can expect to have binaries.pantsbuild.org up, but it seems a bit like an anti-internet move on apparently every OS's part.

EDIT: This change to the example.com https cert isn't coming up after several search attempts and I feel like that's a bit of a big change to not have been announced?

@illicitonion

This comment has been minimized.

Copy link
Contributor

illicitonion commented Nov 28, 2018

Where is this cert stored? It appears trying to access the site https://example.com also shows an error when accessing it from my machine. Why would this cert expire? Is it required to stand up your own website to write integration tests now? This shouldn't be a concern for us as we can expect to have binaries.pantsbuild.org up, but it seems a bit like an anti-internet move on apparently every OS's part.

EDIT: This change to the example.com https cert isn't coming up after several search attempts and I feel like that's a bit of a big change to not have been announced?

example.com is literally just a website on the internet which has its own HTTPS certificate - nothing special about it (other than IANA happen to own it)

@illicitonion illicitonion merged commit 9b027ec into pantsbuild:master Nov 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/example.com branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment