New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused error value. #6834

Merged
merged 1 commit into from Nov 29, 2018

Conversation

Projects
None yet
4 participants
@jsirois
Copy link
Member

jsirois commented Nov 29, 2018

Previously we'd see:

   Compiling ui v0.0.1 (/home/jsirois/dev/pantsbuild/pants/src/rust/engine/ui)
warning: unused `std::result::Result` which must be used
   --> ui/src/display.rs:178:5
    |
178 |     self.flush();
    |     ^^^^^^^^^^^^^
    |
    = note: #[warn(unused_must_use)] on by default
    = note: this `Result` may be an `Err` variant, which should be handled
Fix unused error value.
Previously we'd see:
```
   Compiling ui v0.0.1 (/home/jsirois/dev/pantsbuild/pants/src/rust/engine/ui)
warning: unused `std::result::Result` which must be used
   --> ui/src/display.rs:178:5
    |
178 |     self.flush();
    |     ^^^^^^^^^^^^^
    |
    = note: #[warn(unused_must_use)] on by default
    = note: this `Result` may be an `Err` variant, which should be handled
```

@jsirois jsirois requested a review from blorente Nov 29, 2018

@blorente
Copy link
Contributor

blorente left a comment

Thanks! Sorry I couldn't fix it earlier, but got sidetracked.

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Nov 29, 2018

Looks like this hit #6829. Sorry about that: will take a look today after making progress on some other stuff.

@jsirois jsirois merged commit 743480b into pantsbuild:master Nov 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:rust/ui/propagate_flush_errors branch Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment