New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include uname in rust cache key #6842

Merged
merged 1 commit into from Nov 30, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented Nov 30, 2018

Otherwise dockering Linux on OSX may fetch the OSX generated binary which won't work

Include uname in rust cache key
Otherwise dockering Linux on OSX may fetch the OSX generated binary which won't work

@illicitonion illicitonion requested a review from cosmicexplorer Nov 30, 2018

@jsirois
Copy link
Member

jsirois left a comment

This will be thrashy on developer Linux where you might get a kernel change every few weeks, but it's correct. I may circle back to trim down later.

@illicitonion

This comment has been minimized.

Copy link
Contributor

illicitonion commented Nov 30, 2018

It's just uname, not with any extended info, so would expect just Linux for the most part?

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Nov 30, 2018

Ah, yes. Sorry about that - I was somehow thinking uname -a. LGTM

@illicitonion illicitonion merged commit be75d11 into pantsbuild:master Nov 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/rust/cache-key-uname branch Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment