New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert some of release.sh to python, batch pants invocations #6843

Merged
merged 5 commits into from Dec 10, 2018

Conversation

Projects
None yet
5 participants
@illicitonion
Copy link
Contributor

illicitonion commented Nov 30, 2018

The overhead of each pants invocation is non-trivial.

illicitonion added some commits Nov 30, 2018

Batch setup-py invocataions
The overhead of each pants invocation is non-trivial

@illicitonion illicitonion requested a review from cosmicexplorer Nov 30, 2018

eval $INSTALL_TEST_FUNC ${PIP_ARGS[@]} || \
die "Failed to install and test package ${NAME}-${VERSION}!"
start_travis_section "${package}" "Installing and testing package ${package}-${VERSION}"
eval pkg_${package##*\.}_install_test ${PIP_ARGS[@]} || \

This comment has been minimized.

@illicitonion

illicitonion Nov 30, 2018

Contributor

Note: I renamed a couple of the pkg_..._install_test functions to all adhere to this pattern. They are currently all unique.

local version=$1
execute_pex \
execute_pex --pypi \

This comment has been minimized.

@illicitonion

illicitonion Nov 30, 2018

Contributor

Note: Added --pypi here because we do want to check pypi in calls to release.sh -t

@jsirois
Copy link
Member

jsirois left a comment

Both build-support/README.md and - more importantly - contrib/README.md could use some updates or nuking as the case may be.

@@ -492,6 +436,7 @@ function fetch_and_check_prebuilt_wheels() {
fetch_prebuilt_wheels "${check_dir}"

local missing=()
RELEASE_PACKAGES=($(run_local_pants -q run src/python/pants/releases:packages -- list | grep '.' | awk '{print $1}'))

This comment has been minimized.

@jsirois

jsirois Nov 30, 2018

Member

Maybe extract a small bash funtion for this - it's used 2x and semi-non-straightforward.

@stuhood stuhood requested a review from wisechengyi Nov 30, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Nov 30, 2018

Adding @wisechengyi , because he had previously made changes to the release script which later needed to be reverted due to the bootstrap problem of "using pants to fetch binary copies of pants to ... etc".

@wisechengyi

This comment has been minimized.

Copy link
Contributor

wisechengyi commented Nov 30, 2018

Right, that was #6699. Without looking too closely, I'd encourage you to the test against the pants-publish-release-candidate job to see if you run into any pants bootstrap issues.

Package(
"pantsbuild.pants.contrib.scrooge",
"//contrib/scrooge/src/python/pants/contrib/scrooge:plugin",
),

This comment has been minimized.

@baroquebobcat

baroquebobcat Nov 30, 2018

Contributor

I think you should also update contrib/README.md where it talks about updating these files. It's near
To register with the release script, add an entry to contrib/release_packages.sh:

@illicitonion

This comment has been minimized.

Copy link
Contributor

illicitonion commented Dec 3, 2018

@stuhood @wisechengyi I updated this to use pex27 to run the script, instead of pants (it was only using pants to pull in 3rdparty deps). WDYT?

@illicitonion illicitonion merged commit 5c19c7b into pantsbuild:master Dec 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/release/python-up-build-wheels branch Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment