Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
don't redundantly call environment_as() to avoid an encoding error for mysterious env var value #6846
See https://pantsbuild.slack.com/archives/CB8F24LPM/p1543518771002700 for context -- if that link dies, the issue is: e.g. https://travis-ci.org/pantsbuild/pants/jobs/461402174 on
This appears to trigger nondeterministically. I wouldn't be surprised if the changes in #6824 ended up triggering this, but the real issue is that (it seems) some pants output is being stuffed into an environment variable, and that it happens to not be encoded correctly somehow. I'm not sure why this is the case, but if it is process output of some form, I might be able to see why this is nondeterministic.
So the underlying issue is twofold -- one that we're stuffing process output into an env var (which might be legitimate), and two that we aren't encoding the value of the env var we're setting correctly. For now, this commit allows us to avoid triggering the underlying issue.