New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port a few tests over to the new TestBase. #6854

Merged
merged 3 commits into from Dec 4, 2018

Conversation

Projects
None yet
3 participants
@benjyw
Copy link
Contributor

benjyw commented Dec 2, 2018

No description provided.

@benjyw benjyw requested review from stuhood and wisechengyi Dec 2, 2018

@wisechengyi

This comment has been minimized.

Copy link
Contributor

wisechengyi commented Dec 2, 2018

Does this mean to be incremental? I'd imagine tests/python/pants_test/base_test.py would be removed.

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented Dec 2, 2018

There are other tests still using that base class. This change fixes some, but not all, such tests.

@wisechengyi
Copy link
Contributor

wisechengyi left a comment

Thank you!

@stuhood

stuhood approved these changes Dec 3, 2018

Copy link
Member

stuhood left a comment

Thanks!

@@ -362,6 +362,10 @@ def isolated_local_store(cls):
def build_root(self):
return self._build_root()

@property
def build_file_parser(self):

This comment has been minimized.

@stuhood

stuhood Dec 3, 2018

Member

One note: the new engine does not expose a "BuildFileParser" interface, so I believe that usage of this class actually represents dead (or at least, alive-only-in-tests) code.

This comment has been minimized.

@benjyw

benjyw Dec 3, 2018

Contributor

Yeah, I noticed that, but didn't want to perturb too far...

This comment has been minimized.

@benjyw

benjyw Dec 3, 2018

Contributor

Should I just kill this?

This comment has been minimized.

@stuhood

stuhood Dec 3, 2018

Member

If you have the appetite to, it would definitely be appreciated! Not sure how far reaching it is.

@benjyw benjyw merged commit 32806b9 into pantsbuild:master Dec 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:deprecate_base_test branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment