New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy pre-commit check when used as a commit hook #6859

Merged
merged 1 commit into from Dec 4, 2018

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

stuhood commented Dec 3, 2018

Problem

The new clippy check in pre-commit.sh invokes ci.sh, which does not appear to work in the context of a commit hook (which is a usage suggested by https://www.pantsbuild.org/howto_contribute.html#getting-pants-source-code).

Solution

Extract a clippy check script to remove the need to invoke all of ci.sh.

Extract clippy check script to remove the need to invoke all of `ci.s…
…h`, which might not be safe to run under a git hook.

@stuhood stuhood requested a review from illicitonion Dec 3, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Dec 3, 2018

Confirmed that this works locally by also editing a rust file in this branch.

@jsirois

jsirois approved these changes Dec 3, 2018

@stuhood stuhood merged commit cd638e0 into pantsbuild:master Dec 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/fix-cargo-clippy-locally branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment