Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set -XX:-MaxFDLimit #6863

Merged
merged 1 commit into from Aug 30, 2019

Conversation

@illicitonion
Copy link
Contributor

commented Dec 4, 2018

This should just always be the JVM default.

@illicitonion illicitonion requested a review from stuhood Dec 4, 2018

@stuhood
stuhood approved these changes Dec 4, 2018
@@ -54,7 +54,9 @@ def get_jvm_options(self):
Thus named because get_options() already exists (and returns this object's Pants options).
"""
ret = []
# Always bump MaxFDLimit - this means that Java will listen to the environmental FD limit,
# rather than imposing its own. This should just be what the JVM does by default. Boo.

This comment has been minimized.

Copy link
@stuhood

stuhood Dec 4, 2018

Member

It's hard to come back from making this the default globally like this... are we certain that we want this to be un-removable? Although it would have less "automatic" impact, adding this as the default for the --options would also allow it to be disabled.

This comment has been minimized.

Copy link
@illicitonion

illicitonion Aug 29, 2019

Author Contributor

... 9 months later, done!

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/jvmfds branch from c1cf3ec to 96efd1d Aug 29, 2019

Always set -XX:-MaxFDLimit by default
This should just always be the JVM default.

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/jvmfds branch from 96efd1d to 7e8d087 Aug 29, 2019

@illicitonion illicitonion merged commit 0e1c896 into pantsbuild:master Aug 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/jvmfds branch Aug 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.