New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port remaining tests to new TestBase base class. #6864

merged 2 commits into from Dec 5, 2018


None yet
2 participants
Copy link

benjyw commented Dec 4, 2018

This ports all remaining direct users of the old BaseTest to the new base class. It does not deal with remaining uses of the old pants_test.tasks.TaskTestBase, which extends BaseTest. Only after we do that can we remove BaseTest.

This change also gets rid of BuildFileTestBase. It was only used by one test, FilesystemBuildFileTest, so I inlined the necessary code there. Note that I'm not even sure we still need FilesystemBuildFileTest.

@benjyw benjyw requested review from stuhood and wisechengyi Dec 4, 2018


stuhood approved these changes Dec 4, 2018

Copy link

stuhood left a comment

Thanks a lot!

@benjyw benjyw merged commit dbf063e into pantsbuild:master Dec 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@benjyw benjyw deleted the benjyw:port_tests_to_test_base branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment