New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use __iter__ instead of .dependencies in v2 rules #6873

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented Dec 6, 2018

'dependencies' isn't a very clear name, so avoid using it

Use __iter__ instead of .dependencies in v2 rules
'dependencies' isn't a very clear name, so avoid using it

@illicitonion illicitonion requested a review from stuhood Dec 6, 2018

@stuhood

stuhood approved these changes Dec 6, 2018

@illicitonion illicitonion merged commit e107ad6 into pantsbuild:master Dec 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/removedeps branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment