New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush the console after all @console_rules have completed #6878

Merged
merged 2 commits into from Dec 7, 2018

Conversation

Projects
None yet
3 participants
@stuhood
Copy link
Member

stuhood commented Dec 6, 2018

Problem

I noticed some flakiness while using --no-v1 --v2 list under pantsd, and diffing the output of a successful and unsuccessful run indicated that it was an issue with truncation.

Solution

Add and use Console.flush() after all @console_rules have completed.

Result

I'm fairly sure that this fixes #6782: unmarking it here.

@stuhood stuhood requested review from benjyw and illicitonion Dec 6, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Dec 7, 2018

Hmmm. Nope!.

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Dec 7, 2018

Ok, there was an unrelated network flake, but I think that this does actually solve this issue. Am going to re-run the relevant shard to confirm, but this is ready for review.

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Dec 7, 2018

(integration test shard 2 is the one to watch.)

@Eric-Arellano
Copy link
Contributor

Eric-Arellano left a comment

Yay for fixing flakes!

@stuhood stuhood merged commit 84b152c into pantsbuild:master Dec 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/flush-the-console branch Dec 7, 2018

@benjyw
Copy link
Contributor

benjyw left a comment

LGTM sorry for delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment