New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] - Fix python/tasks unicode issues for Python 3 integration tests #6887

Merged
merged 2 commits into from Dec 8, 2018

Conversation

Projects
None yet
3 participants
@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Dec 7, 2018

stdout was not being decoded into unicode, so Py3 was throwing TypeErrors.

Eric-Arellano added some commits Dec 7, 2018

Fix interpreter_selection_integration unicode issues
stdout was not being decoded into unicode, so Py3 was throwing TypeErrors.

@Eric-Arellano Eric-Arellano requested a review from stuhood Dec 7, 2018

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor

Eric-Arellano commented Dec 7, 2018

Note I can't remove backend/python/tasks from blacklist because there are other remaining issues, such as the Thrift PR.

@Eric-Arellano Eric-Arellano changed the title [Bug fix] - Fix python tasks unicode issues for Python 3 [Bug fix] - Fix python/tasks unicode issues for Python 3 integration tests Dec 7, 2018

@stuhood

stuhood approved these changes Dec 7, 2018

@Eric-Arellano Eric-Arellano merged commit 4a674af into pantsbuild:master Dec 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:py3-python-tasks-unicode branch Dec 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment