Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
make a rust ruleset to wrap cargo and build the native engine #6891
It would be great if we could use pants to build the native engine instead of a bunch of (very nice) shell scripts. See the "Result" section for how I plan to obtain a pair of pants in order to run this ruleset.
After discussion with @stuhood, we think one possible way to use these rules is to modify the
I could probably use an
There are a lot of
illicitonion left a comment
This is really exciting, thanks for putting it together! I think there are ~2 pieces of work we should do before we can merge...
We definitely shouldn't be exposing
stuhood left a comment
This is pretty awesome, thanks!
I think that it currently violates a few too many of the Engine's "laws" to be safe to land. The big pieces are: 1) getting things into
We should definitely have tickets/design for 1 and 3 before landing this. We should also most likely have implemented one or both of those things.
2 is trickier... we should definitely not be doing this, but we don't currently have a way to enforce that. Design of enforcement is ... larger, and thus probably not a blocker for landing. But we definitely can't land