New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Task fingerprinting. #6894

Merged
merged 2 commits into from Dec 11, 2018

Conversation

Projects
None yet
4 participants
@jsirois
Copy link
Member

jsirois commented Dec 10, 2018

Previously transitive Subsystem dependencies did not count against the
task fingerprint which was a known, latent and slient bug.

Fixes #2739

Fix Task fingerprinting.
Previously transitive Subsystem dependencies did not count against the
task fingerprint which was a known, latent and slient bug.

Fixes #2739
@Eric-Arellano
Copy link
Contributor

Eric-Arellano left a comment

(Sorry if this wasn't ready for review yet - leaving for trip soon)

Looks good to me! Recursion makes this solution very elegant.

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

Fixes driven by review feedback.
+ Make test iteration order agnostic.
+ Improve subsystem_closure_iter API - don't leak `seen`.

Also detect cycles and add a test for this.
@Eric-Arellano
Copy link
Contributor

Eric-Arellano left a comment

Changes look great. Thanks!

@jsirois jsirois merged commit 537e163 into pantsbuild:master Dec 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/2739 branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment