New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky `test_process_request_*`. #6895

Merged
merged 1 commit into from Dec 11, 2018

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

jsirois commented Dec 10, 2018

The process_request method is inherently racey to test; it's library
code that spawns a thread and provides no handle to it. Switch the
tests to exercise the underlying process_request_thread since that is
what we implement anyhow and which has no threading.

Fixes #6877

Fix flaky `test_process_request_*`.
The `process_request` method is inherently racey to test; it's library
code that spawns a thread and provides no handle to it. Switch the
tests to exercise the underlying `process_request_thread` since that is
what we implement anyhow and which has no threading.

Fixes #6877
@Eric-Arellano
Copy link
Contributor

Eric-Arellano left a comment

Thanks!

@jsirois jsirois merged commit 703bcb2 into pantsbuild:master Dec 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/6877 branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment