New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure pants is running in exception sink tests. #6912

Merged
merged 2 commits into from Dec 12, 2018

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

jsirois commented Dec 12, 2018

Previously, pants was run asynchronously with no way to guaranty it was
up and initialized the way we expected it to be before testing its
signal handling. Introduce a phaser testproject target that allows the
integration test to ensure the pants run state is as expected.

Fixes #6847

Ensure pants is running in excpetions sink tests.
Previously, pants was run asynchronously with no way to guaranty it was
up and initialized the way we expected it to be before testing its
signal handling. Introduce a phaser testproject target that allows the
integration test to ensure the pants run state is as expected.

Fixes #6787
@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Dec 12, 2018

Side benefit, tests in this file go from 260s to 22s.

@jsirois jsirois requested a review from cosmicexplorer Dec 12, 2018

@jsirois jsirois changed the title Ensure pants is running in excpetions sink tests. Ensure pants is running in exception sink tests. Dec 12, 2018

@cosmicexplorer
Copy link
Contributor

cosmicexplorer left a comment

Reducing the test time here is fantastic -- this may also be relevant for the errors in run tracker counting in #6574 (or maybe that's still my fault). How specifically did you ascertain the change in time taken to run this test in CI?


# Signal we've arrived.
with open(arrive_file, 'w') as fp:
fp.close()

This comment has been minimized.

@cosmicexplorer

cosmicexplorer Dec 12, 2018

Contributor

Just a question -- does "phaser" refer to some construction/method I'm not familiar with? I haven't heard the term before.

This comment has been minimized.

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Dec 12, 2018

How specifically did you ascertain the change in time taken to run this test in CI?

I didn't. This was the timing locally before and after. Looking at waiter.py - uninterrupted (meant to be used with creator.py) it runs at least 60s. There were 4 full waits here, so the tests always would have to take at least 240s plus change by design.

@jsirois jsirois merged commit 2f05f0a into pantsbuild:master Dec 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/6787 branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment