New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump scalafix version and use os.pathsep #6938

Merged
merged 1 commit into from Dec 15, 2018

Conversation

Projects
None yet
6 participants
@woparry
Copy link
Contributor

woparry commented Dec 15, 2018

Problem

--tool-classpath from #6926 isn't supported in the default scalafix version, and ':' was hardcoded as path separator. This meant it would break on windows, and this option wouldn't work on default pants install.

Solution

Bump the scalafix version, and use os.pathsep.

Result

Things will work out of the box.

@Eric-Arellano
Copy link
Contributor

Eric-Arellano left a comment

os.pathsep change looks great! I'm curious if we're hardcoding : in other places.

@jsirois
Copy link
Member

jsirois left a comment

Thanks so much for circling back!

@stuhood stuhood merged commit 126c311 into pantsbuild:master Dec 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood added this to To Do in Python Pipeline Porting via automation Dec 15, 2018

@stuhood stuhood removed this from To Do in Python Pipeline Porting Dec 15, 2018

@stuhood stuhood added this to the 1.13.x milestone Dec 15, 2018

illicitonion added a commit to twitter/pants that referenced this pull request Dec 17, 2018

Bump scalafix version and use os.pathsep (pantsbuild#6938)
### Problem

--tool-classpath from pantsbuild#6926 isn't supported in the default scalafix version, and ':' was hardcoded as path separator. This meant it would break on windows, and this option wouldn't work on default pants install.

### Solution

Bump the scalafix version, and use os.pathsep.

### Result

Things will work out of the box.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment