Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run clean-all before switching pants python version runner scripts #7151

Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
7cf44e5
run clean-all before switching pants python version runner scripts
cosmicexplorer Jan 25, 2019
d16c292
add sentinel file to gitignore, with an issue link
cosmicexplorer Jan 25, 2019
c003ebc
respond to review comments
cosmicexplorer Jan 25, 2019
9d5eb2b
introduce a temporary env var to avoid triggering a clean in CI
cosmicexplorer Jan 25, 2019
78dac49
don't use an environment variable, just check tty before cleaning
cosmicexplorer Jan 28, 2019
abdb335
add set -x to trace what's failing
cosmicexplorer Jan 29, 2019
e8c3060
Revert "add set -x to trace what's failing"
cosmicexplorer Feb 3, 2019
e7e8ab1
correctly check whether we are in the CI environment
cosmicexplorer Feb 6, 2019
82d193f
try adding an env var to .travis.yml again
cosmicexplorer Feb 7, 2019
3b9d1e6
copy the single python version env var to the wheel building shards
cosmicexplorer Feb 10, 2019
0658c8b
add ONLY_USING_SINGLE_PYTHON_VERSION to all docker command lines
cosmicexplorer Mar 10, 2019
a96856e
move ONLY_USING_SINGLE_PYTHON_VERSION to the travis_ci Dockerfile
cosmicexplorer Mar 10, 2019
aecfc2b
add the env var to the ucs2 dockerfile as well
cosmicexplorer Mar 10, 2019
0a26141
use full python version for output file
cosmicexplorer Mar 10, 2019
25e0023
refactor interpreter checking logic
cosmicexplorer Mar 10, 2019
2efeb79
respond to review comments
cosmicexplorer Mar 11, 2019
075a7d2
remove references to #7152
cosmicexplorer Mar 13, 2019
0642281
move .pants-python-version to .pants.d!
cosmicexplorer Mar 13, 2019
30667d0
use interpreter constraints as the cache key and remove unnecessary e…
cosmicexplorer Mar 15, 2019
760edec
respond to review comments
cosmicexplorer Mar 15, 2019
4693413
move interpreter constraints file out of .pants.d AND make interprete…
cosmicexplorer Mar 16, 2019
107d821
add ONLY_USING_SINGLE_PYTHON_VERSION to hermetic env whitelist
cosmicexplorer Mar 16, 2019
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

add ONLY_USING_SINGLE_PYTHON_VERSION to all docker command lines

  • Loading branch information...
cosmicexplorer committed Mar 10, 2019
commit 0658c8b1224065dc274cb136c290e0b0c686104d
@@ -20,7 +20,7 @@ env:
- PYTEST_PASSTHRU_ARGS="-v --duration=3"
- LC_ALL="en_US.UTF-8"
# TODO(#7152): this tells the ./pants runner script to avoid trying to clean the workspace when
# changing python versions. Remove this after the python 3 migration!
# changing python versions. Remove all instances of this after the python 3 migration!
- ONLY_USING_SINGLE_PYTHON_VERSION='true'
- BOOTSTRAPPED_PEX_BUCKET=ci-public.pantsbuild.org
- BOOTSTRAPPED_PEX_KEY_PREFIX=${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex
@@ -465,7 +465,7 @@ py27_osx_build_wheels_ucs2: &py27_osx_build_wheels_ucs2
- CACHE_NAME=osxwheelsbuild.ucs2
script:
- ./build-support/bin/check_pants_pex_abi.py cp27m
- RUN_PANTS_FROM_PEX=1 ./build-support/bin/release.sh -n
- RUN_PANTS_FROM_PEX=1 ONLY_USING_SINGLE_PYTHON_VERSION='true' ./build-support/bin/release.sh -n

py27_osx_build_wheels_ucs4: &py27_osx_build_wheels_ucs4
<<: *py27_osx_config
@@ -498,7 +498,7 @@ py27_osx_build_wheels_ucs4: &py27_osx_build_wheels_ucs4
script:
- ./build-support/bin/ci.sh -2b
- ./build-support/bin/check_pants_pex_abi.py cp27mu
- RUN_PANTS_FROM_PEX=1 ./build-support/bin/release.sh -n
- RUN_PANTS_FROM_PEX=1 ONLY_USING_SINGLE_PYTHON_VERSION='true' ./build-support/bin/release.sh -n

# -------------------------------------------------------------------------
# Rust tests
@@ -13,7 +13,7 @@ env:
- PYTEST_PASSTHRU_ARGS="-v --duration=3"
- LC_ALL="en_US.UTF-8"
# TODO(#7152): this tells the ./pants runner script to avoid trying to clean the workspace when
# changing python versions. Remove this after the python 3 migration!
# changing python versions. Remove all instances of this after the python 3 migration!
- ONLY_USING_SINGLE_PYTHON_VERSION='true'
- BOOTSTRAPPED_PEX_BUCKET=ci-public.pantsbuild.org
- BOOTSTRAPPED_PEX_KEY_PREFIX=${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex
@@ -418,7 +418,7 @@ py27_osx_build_wheels_ucs2: &py27_osx_build_wheels_ucs2
- CACHE_NAME=osxwheelsbuild.ucs2
script:
- ./build-support/bin/check_pants_pex_abi.py cp27m
- RUN_PANTS_FROM_PEX=1 ./build-support/bin/release.sh -n
- RUN_PANTS_FROM_PEX=1 ONLY_USING_SINGLE_PYTHON_VERSION='true' ./build-support/bin/release.sh -n
py27_osx_build_wheels_ucs4: &py27_osx_build_wheels_ucs4
<<: *py27_osx_config
@@ -445,7 +445,7 @@ py27_osx_build_wheels_ucs4: &py27_osx_build_wheels_ucs4
script:
- ./build-support/bin/ci.sh -2b
- ./build-support/bin/check_pants_pex_abi.py cp27mu
- RUN_PANTS_FROM_PEX=1 ./build-support/bin/release.sh -n
- RUN_PANTS_FROM_PEX=1 ONLY_USING_SINGLE_PYTHON_VERSION='true' ./build-support/bin/release.sh -n
# -------------------------------------------------------------------------
# Rust tests
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.