Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for releasing Python 3 wheels #7197

Merged
merged 31 commits into from Mar 14, 2019
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
1b556c9
Implement #6450
Eric-Arellano Jan 31, 2019
448c898
Remove pants_requirement.py env marker
Eric-Arellano Jan 31, 2019
539f1a3
Add py3 option to packages.py
Eric-Arellano Jan 31, 2019
179acca
Fix bad subprocess32 import for packages.py
Eric-Arellano Jan 31, 2019
9f7f204
Add -3 arg to release.sh & py3 support
Eric-Arellano Jan 31, 2019
d09fdc3
Add Py3 build wheel shards
Eric-Arellano Jan 31, 2019
f1812b8
Change pantsbuild.pants tag to use abi3
Eric-Arellano Feb 1, 2019
dae8385
Fix invalid travis entry
Eric-Arellano Feb 1, 2019
addd127
Remove leftover env_marker in pants_requirement.py
Eric-Arellano Feb 1, 2019
0ea887e
Clarify why --py3 must be passed first
Eric-Arellano Feb 1, 2019
af968c1
Merge branch 'master' of github.com:pantsbuild/pants into py3-wheels
Eric-Arellano Feb 5, 2019
5c493b0
Modify Pants BUILD to get ABI setting to apply
Eric-Arellano Feb 5, 2019
ce9445c
Constrain subprocesses to Py3 in releases.sh
Eric-Arellano Feb 5, 2019
dc85e1b
Squashed commit of the following:
Eric-Arellano Feb 27, 2019
bcd86ea
Merge branch 'master' of github.com:pantsbuild/pants into py3-wheels
Eric-Arellano Feb 27, 2019
aae3a5d
Use Pex36, not Pex37
Eric-Arellano Feb 27, 2019
b470c00
Merge branch 'master' of github.com:pantsbuild/pants into py3-wheels
Eric-Arellano Mar 9, 2019
c2c51d0
Simplify handling of requirements
Eric-Arellano Mar 9, 2019
3d1bca8
Merge branch 'master' of github.com:pantsbuild/pants into py3-wheels
Eric-Arellano Mar 10, 2019
3c93b79
Update expected number of wheels
Eric-Arellano Mar 10, 2019
c60b030
Move getopt reset to top of file
Eric-Arellano Mar 10, 2019
7f14443
-3 is not mutually exclusive
Eric-Arellano Mar 10, 2019
31de68e
Move usage() back down to bottom
Eric-Arellano Mar 10, 2019
1e1ed4e
Change expected pants.pex abi to cp36m
Eric-Arellano Mar 10, 2019
7beb55e
Improve readability of release.sh expected interpreter
Eric-Arellano Mar 10, 2019
0c3ccca
Improve comment in packages.py
Eric-Arellano Mar 10, 2019
789bb15
Remove unit test check for PantsRequirement interpreter constraints
Eric-Arellano Mar 11, 2019
aa33854
Merge branch 'master' of github.com:pantsbuild/pants into py3-wheels
Eric-Arellano Mar 11, 2019
a292f73
Fix typo with default env var arg
Eric-Arellano Mar 12, 2019
ea40d0f
Merge branch 'master' of github.com:pantsbuild/pants into py3-wheels
Eric-Arellano Mar 12, 2019
1090078
Fix bad docker image from #7352
Eric-Arellano Mar 12, 2019
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Clarify why --py3 must be passed first

It's because of subparsers. Make this explicit, rather than implicit.
  • Loading branch information...
Eric-Arellano committed Feb 1, 2019
commit 0ea887e693ecd380c1454e48a00ab0e05daaaa13
@@ -252,7 +252,8 @@ def check_ownership(i, package):

def _create_parser():
parser = argparse.ArgumentParser()
# Note --py3 flag must be passed as first arg
# Note because of how argparse handles subparsers, the --py3 flag must be passed before any of the subparser
# flags to resolve properly.
parser.add_argument("-3", "--py3", action="store_true", default=False, help="Release any non-universal packages as Python 3.")
subparsers = parser.add_subparsers(dest="command")
# list
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.