Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Avoid capturing Snapshots for previously digested codegen outputs #7241
As described in #7229, re-capturing
Remove features from the python-exposed
2 times, most recently
Feb 13, 2019
illicitonion left a comment
Currently Snapshots are ordering-sensitive, and this is relied on in a few places (specifically wire protobuf generation, IIRC). This Digest -> Snapshot hydration doesn't preserve order, which may lead to sneaky bugs.
I think that means we should probably block merging this on fixing #5802?
Otherwise, looks great :)