Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out rsc distribution selection into JvmCompile #7290

Conversation

Projects
None yet
3 participants
@cosmicexplorer
Copy link
Contributor

commented Feb 26, 2019

Problem

See #7272 (comment). We are selecting the jvm distribution in a pretty manual way in rsc_compile.py that might benefit from being extracted into the JvmCompile base class.

Solution

  • Move _get_jvm_distribution() from RscCompile into JvmCompile.
  • Use that logic to simplify ZincCompile#_get_zinc_arguments().

Result

Distribution selection, and in particular preparing the distribution to be usable in a hermetic context, is extracted into a common method in the jvm compile base class.

@baroquebobcat
Copy link
Contributor

left a comment

Looks good to me!

cosmicexplorer added some commits Feb 26, 2019

@cosmicexplorer cosmicexplorer force-pushed the cosmicexplorer:split-out-distribution-selection-into-jvm-compile-base branch from 29d7506 to 3461a85 Feb 28, 2019

@cosmicexplorer

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

Just rebased past #7272, no major changes.

@baroquebobcat

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

👍

@cosmicexplorer cosmicexplorer merged commit ddcae20 into pantsbuild:master Feb 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

cosmicexplorer added a commit that referenced this pull request Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.