Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rsc-compile] extract helper methods for tests #7294

Merged
merged 3 commits into from Mar 5, 2019

Conversation

Projects
None yet
2 participants
@baroquebobcat
Copy link
Contributor

commented Feb 28, 2019

Problem

The rsc tests are a bit unwieldy.

Solution

Extract helper methods and reformat them so they're easier to follow.

Result

The tests are easier to follow, and extend.

@baroquebobcat baroquebobcat requested a review from cosmicexplorer Feb 28, 2019

context = self.context(target_roots=target_roots)
self.init_products(context)
task = self.create_task(context)
# tried for options, but couldn't get it to reconfig

This comment has been minimized.

Copy link
@cosmicexplorer

cosmicexplorer Feb 28, 2019

Contributor

Is this referring to not being able to set the size estimator using a task option?

This comment has been minimized.

Copy link
@baroquebobcat

baroquebobcat Feb 28, 2019

Author Contributor

yes.

@baroquebobcat baroquebobcat merged commit 91f8976 into pantsbuild:master Mar 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.