Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rsc-compile] extract helper methods for tests #7294

merged 3 commits into from Mar 5, 2019


None yet
2 participants
Copy link

commented Feb 28, 2019


The rsc tests are a bit unwieldy.


Extract helper methods and reformat them so they're easier to follow.


The tests are easier to follow, and extend.

@baroquebobcat baroquebobcat requested a review from cosmicexplorer Feb 28, 2019

context = self.context(target_roots=target_roots)
task = self.create_task(context)
# tried for options, but couldn't get it to reconfig

This comment has been minimized.

Copy link

cosmicexplorer Feb 28, 2019


Is this referring to not being able to set the size estimator using a task option?

This comment has been minimized.

Copy link

baroquebobcat Feb 28, 2019

Author Contributor


@baroquebobcat baroquebobcat merged commit 91f8976 into pantsbuild:master Mar 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.