Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Context.build_file_parser. #7295

Merged

Conversation

Projects
None yet
2 participants
@benjyw
Copy link
Contributor

commented Feb 28, 2019

Some tasks rely on it for access to target aliases.
These can be retrieved from the BuildConfiguration instead.

However since Context is public API, we go through a deprecation
cycle before removing the build_file_parser property.

Once this deprecation is complete, we can get rid of BuildFileParser
entirely.

@benjyw benjyw requested a review from stuhood Feb 28, 2019

@stuhood

stuhood approved these changes Mar 1, 2019

Copy link
Member

left a comment

Argh... so close. Thanks for doing this!

benjyw added some commits Feb 28, 2019

Deprecate Context.build_file_parser.
Some tasks rely on it for access to target aliases.
These can be retrieved from the BuildConfiguration instead.

However since Context is public API, we go through a deprecation
cycle before removing the build_file_parser property.

Once this deprecation is complete, we can get rid of BuildFileParser
entirely.
Fix a super() call.
Bring on python3!

@benjyw benjyw force-pushed the benjyw:deprecate_build_file_parser_in_context branch from c2a0743 to a2cbc9e Mar 1, 2019

@stuhood

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

I think that you should just be able to delete the BuildFileParser tests... the thing that they are testing is not used anywhere.

@benjyw

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2019

Remaining failure is a known flake, so merging.

@benjyw

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2019

I'd rather not delete the test until the deprecation cycle is complete. A BuildFileParser is still technically retrievable as part of the public API until then... In practice I'm sure you're right, and no one is using that even outside our repo, but I'd rather err on the side of caution, and of respecting our deprecation principles...

@benjyw benjyw merged commit a286268 into pantsbuild:master Mar 3, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@benjyw benjyw deleted the benjyw:deprecate_build_file_parser_in_context branch Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.