Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
use `type=` to register enum options #7304
Resolves #7233. We want to make it easy and natural to register enum options, and one way to improve that is to automatically convert options registered as enums to instances of those enums.
Registering options as enum classes is much more natural, and has a better error message!
Eric-Arellano left a comment
Question, with uses of
2 times, most recently
Mar 2, 2019
Changed to instead explicitly just
There were multiple changes I made just now to pass testing (or at least all the errors I saw in previous CI runs):
I might ask for a re-review once this goes green (I did not realize these changes would be required to do this) -- but I don't expect there to be further surprises as everything I've tried passes locally.