Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip GraphIntegrationTest.test_error_message as it's flaky in CI. #7309

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@benjyw
Copy link
Contributor

commented Mar 3, 2019

No description provided.

@benjyw

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2019

See #6787

@cosmicexplorer
Copy link
Contributor

left a comment

I think this might be addressable by changing the specific object it's looking for to something not filesystem-related, and will look into this. The GlobMatchErrorBehavior definitely shouldn't be changing like that regardless, but it may be possible that the flakiness can be isolated to that logic.

@cosmicexplorer

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

Hilariously this PR also had a flake, which I've turned into #7314. I don't know how to push a commit and restarting builds after a day with the new CI seems to consistently cause everything to fail downloading a pex (even though the pex creation shards get re-run), so I think you might have to push a new commit. I am going to restart the build now and see if that works, though.

@benjyw benjyw force-pushed the benjyw:skip_flaky_test_error_message branch from df4687a to 555cb86 Mar 6, 2019

@benjyw benjyw merged commit 7df2fa0 into pantsbuild:master Mar 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:skip_flaky_test_error_message branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.