Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression to python interpreter selection test from #7257 #7333

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

commented Mar 7, 2019

Problem

#7257 resulted in test_pytest_run.py::test_target_constraints_with_no_sources failing because ci.sh now sets interpreter constraints for Py2 runs whereas it earlier did not set any. So, the test is pulling in the global interpreter constraints and failing to find an acceptable interpreter.

Solution

Set the test to be hermetic, so that external dependencies aren't pulled in.

Result

PY=python2.7 PANTS_PYTHON_SETUP_INTERPRETER_CONSTRAINTS="['CPython==2.7.15']" ./pants clean-all test tests/python/pants_test/backend/python/tasks:integration -- -k test_target_constraints_with_no_sources now passes.

@Eric-Arellano Eric-Arellano requested a review from stuhood Mar 7, 2019

@stuhood

stuhood approved these changes Mar 7, 2019

Copy link
Member

left a comment

Thanks!

@Eric-Arellano Eric-Arellano merged commit 59d92ea into pantsbuild:master Mar 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:fix-test-target-constraints-regression branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.