Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix names of listtargets and sorttargets files #7358

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
3 participants
@cheister
Copy link
Contributor

commented Mar 11, 2019

Problem

The names for src/python/pants/backend/graph_info/tasks/sorttargets.py and src/python/pants/backend/graph_info/tasks/listtargets.py need an underscore added.

Any reason we shouldn't do this?

Solution

Rename files

Result

Files follow regular python naming standard.

@cheister cheister requested a review from stuhood Mar 11, 2019

@Eric-Arellano
Copy link
Contributor

left a comment

Thanks!

@cheister cheister merged commit 01a9f8b into pantsbuild:master Mar 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cheister cheister deleted the cheister:rename-listtargets-sorttargets branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.