Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of legacy venv folder names leftover from #7187 #7359

Merged

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

commented Mar 11, 2019

#7187 renamed our venv folder scheme from py{2,3}.venv to py{27,36,37}.venv.

We forgot to update two places in documentation to use the new scheme, and one one place in our clean.sh meaning that the script would not actually remove the current venv folders.

@Eric-Arellano Eric-Arellano requested review from stuhood and illicitonion Mar 11, 2019

@Eric-Arellano Eric-Arellano merged commit ecd1554 into pantsbuild:master Mar 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:cleanup-venv-folder-names branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.